mysql84: fix build for Darwin and llvm19

[rsynnest]

• Fixes Build failure: mysql84 and mysql80 on ARM MacOS #371921
• Adds -Wno-missing-template-arg-list-after-template-kw' clang flag to prevent errors on Darwin
• Also fixes broken mysql84 builds due to unsigned char change in LLVM 19. This fix is not specific to aarch64-darwin copied directly from the FreeBSD patch https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280695

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[shyim]

thanks! :)

[paparodeo]

can use the upstream patches with a minor modification

use upstream patches

diff --git a/pkgs/by-name/my/mysql84/package.nix b/pkgs/by-name/my/mysql84/package.nix
index 075c39763ae7..31195155dd1f 100644
--- a/pkgs/by-name/my/mysql84/package.nix
+++ b/pkgs/by-name/my/mysql84/package.nix
@@ -2,6 +2,8 @@
   lib,
   stdenv,
   fetchurl,
+  fetchpatch,
+  substitute,
   bison,
   cmake,
   pkg-config,
@@ -42,6 +44,23 @@ stdenv.mkDerivation (finalAttrs: {
 
   patches = [
     ./no-force-outline-atomics.patch # Do not force compilers to turn on -moutline-atomics switch
+    (substitute {
+      src = fetchpatch {
+        url = "https://github.com/mysql/mysql-server/commit/3a51d7fca76e02257f5c42b6a4fc0c5426bf0421.patch";
+        hash = "sha256-MFmY/HyDoMw3lD64qJkfdadXVkk+gukSs2f80Q/SKlY=";
+      };
+      substitutions = [
+        "--replace-fail" "/mysys/stream_cipher.h" "/sql/stream_cipher.h"
+      ];
+    })
+    (fetchpatch {
+      url = "https://github.com/mysql/mysql-server/commit/94691ac8f5156c7e6c16a954a10bce08bd9d4a7f.patch";
+      hash = "sha256-Jp5Nch1cIgjoYau9GeTQgTPwVvpFI8kMXRHN2w3CMaA=";
+    })
+    (fetchpatch {
+      url = "https://github.com/mysql/mysql-server/commit/4a5c00d26f95faa986ffed7a15ee15e868e9dcf2.patch";
+      hash = "sha256-MEl1lQlDYtFjHk0+S02RQFnxMr+YeFxAyNjpDtVHyeE=";
+    })
   ];
 
   ## NOTE: MySQL upstream frequently twiddles the invocations of libtool. When updating, you might proactively grep for libtool references.