Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud-hypervisor: backport UB fix in kvm-ioctls #373682

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

alyssais
Copy link
Member

VFIO is broken on x86_64 as a result of UB in kvm-ioctls with LLVM 19, which is currently in staging-next. This backports the fix.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

VFIO is broken on x86_64 as a result of UB in kvm-ioctls with LLVM 19,
which is currently in staging-next.  This backports the fix.
@alyssais alyssais requested a review from astro January 14, 2025 09:41
@alyssais alyssais merged commit 66be312 into NixOS:master Jan 15, 2025
23 of 26 checks passed
@alyssais alyssais deleted the cloud-hypervisor-ub branch January 15, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant