-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: switch to NIXPKGS_CI specific variables #373935
Conversation
As per NixOS/org#54, new variables are now NIXPKGS_CI_APP_ID and NIXPKGS_CI_APP_PRIVATE_KEY.
Humm, seems like secrets are not being passed properly? https://github.com/NixOS/nixpkgs/actions/runs/12781938173/job/35630648144 |
Apparently since we are callling a reusable workflow here, we need to explicitly pass the secrets. :(
Nice, looks like this works now! https://github.com/NixOS/nixpkgs/actions/runs/12782225893/job/35631361946 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Should we use the new token for the codeowners workflow, too? (Not sure whether it has the right permissions)
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-373935-to-release-24.11 origin/release-24.11
cd .worktree/backport-373935-to-release-24.11
git switch --create backport-373935-to-release-24.11
git cherry-pick -x f6976283058deb6d6eaa30967c09b4ee471e3193 6ab6314d06d25d77c3052fb00c4bdf3d7a5027a2 38ebbf7c4fc018170ac80582f83eb076694ab010 |
Because I was confused for a sec: This PR doesn't need to be backported because:
|
Correct - I tried backporting to minimize conflicts, but then concluded the same. |
This will allow GitHub to run actions on those commits, specifically Eval action. Currently as these merges are commited by
github-actions
, Eval doesn't run on the commits.ie, https://github.com/NixOS/nixpkgs/actions/runs/12646467735/job/35237397411?pr=371701 Processing failed due to fa2d66f commit was done by github-actions.
With this every periodic merge will be authored and commited by the nixpkgs-ci bot.
Supercedes #372041
Relevant org discussion: NixOS/org#54
PR created from a NixOS/nixpkgs branch as to make it easier to test.