Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.11]: pnpm_10: init at 10.0.0 #374069

Closed
wants to merge 1 commit into from

Conversation

Scrumplex
Copy link
Member

Partial backport of #371832

(cherry picked from commit 1187945)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

(cherry picked from commit 1187945)
@gepbird
Copy link
Contributor

gepbird commented Jan 15, 2025

Shouldn't we also backport pinning pnpm to pnpm_9 (#374000)? If we don't do that I think there will be many failed automatic package backports.

@Scrumplex
Copy link
Member Author

Shouldn't we also backport pinning pnpm to pnpm_9 (#374000)? If we don't do that I think there will be many failed automatic package backports.

Sure, but we would have to skip the change that switches pnpm to pnpm_10

@wolfgangwalther
Copy link
Contributor

Let's do #374000 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants