Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghidra: fix build on gradle 8.12 #374706

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Conversation

jchv
Copy link
Contributor

@jchv jchv commented Jan 18, 2025

Fixes #374703. The build is still broken on macOS.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jchv jchv force-pushed the fix/ghidra-gradle-8.12 branch from bc1e22d to 8308da2 Compare January 18, 2025 03:40
@chivay
Copy link
Member

chivay commented Jan 18, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374706


x86_64-linux

✅ 10 packages built:
  • ghidra
  • ghidra-extensions.findcrypt
  • ghidra-extensions.ghidra-delinker-extension
  • ghidra-extensions.ghidra-golanganalyzerextension
  • ghidra-extensions.gnudisassembler
  • ghidra-extensions.lightkeeper
  • ghidra-extensions.machinelearning
  • ghidra-extensions.ret-sync
  • ghidra-extensions.sleighdevtools
  • ghidra-extensions.wasm

@K900 K900 merged commit 620dd33 into NixOS:master Jan 18, 2025
25 of 27 checks passed
@jchv jchv deleted the fix/ghidra-gradle-8.12 branch January 18, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: ghidra
5 participants