xwax: init at version 1.9 #377421
Open
xwax: init at version 1.9 #377421
+62
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
the
8.has: maintainer-list (update)
|
You'll want to squash these commits and change the commit styles for match our styleguide. |
obsoleszenz
force-pushed
the
xwax
branch
2 times, most recently
from
aa6673e to
9c19b4f
Compare
Did so :) |
github-actions
bot
added
10.rebuild-darwin: 0
|
I hate to be nitpicky but the maintainer addition needs to be in a separate commit ;) |
No worries, split it into two commits. Does the ordering of the commits matter? |
ethancedwards8
approved these changes
Jan 29, 2025
Defelo
reviewed
Jan 29, 2025
Comment on lines
+48
to
+55
| meta = with lib; { | ||
| homepage = "https://xwax.org"; | ||
| description = "Digital vinyl on Linux"; | ||
| mainProgram = "xwax"; | ||
| license = licenses.gpl3; | ||
| maintainers = with maintainers; [ obsoleszenz ]; | ||
| platforms = platforms.linux; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| homepage = "https://xwax.org"; | |
| description = "Digital vinyl on Linux"; | |
| mainProgram = "xwax"; | |
| license = licenses.gpl3; | |
| maintainers = with maintainers; [ obsoleszenz ]; | |
| platforms = platforms.linux; | |
| }; | |
| meta = { | |
| homepage = "https://xwax.org"; | |
| description = "Digital vinyl on Linux"; | |
| mainProgram = "xwax"; | |
| license = lib.licenses.gpl3; | |
| maintainers = with lib.maintainers; [ obsoleszenz ]; | |
| platforms = lib.platforms.linux; | |
| }; |
| cp xwax $out/bin/xwax | ||
| runHook postInstall | ||
| ''; | ||
|
|
There was a problem hiding this comment.
Suggested change
| nativeInstallCheckInputs = [ versionCheckHook ]; | |
| versionCheckProgramArg = "--version"; | |
| doInstallCheck = true; | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISCLAIMER: This is the first time i'm contributing to nixpkgs
Adds xwax v1.9 (latest)
xwax is an open-source Digital Vinyl System (DVS) for Linux. It allows DJs and turntablists to playback digital audio files (MP3, Ogg Vorbis, FLAC, AAC and more), controlled using a normal pair of turntables via timecoded vinyls.
It's designed for both beat mixing and scratch mixing. Needle drops, pitch changes, scratching, spinbacks and rewinds are all supported, and feel just like the audio is pressed onto the vinyl itself.
The focus is on an accurate vinyl feel which is efficient, stable and fast.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.