Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sideband: init at 1.3.0 #378373

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jan 31, 2025

Things done

Add sideband, an LXMF client allowing you to communicate with people or LXMF-compatible systems over Reticulum networks.

  • python312Packages.ffpyplayer: init at 4.5.2
  • python312Packages.pycodec2: init at 4.0.0
  • python312Packages.pyobjus: init at 1.2.3
  • sideband: init at 1.3.0

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

sideband builds, but pyobjus (darwin dependency) doesn't.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 378373


x86_64-linux

❌ 4 packages failed to build:
  • python312Packages.pyobjus
  • python312Packages.pyobjus.dist
  • python313Packages.pyobjus
  • python313Packages.pyobjus.dist
✅ 10 packages built:
  • python312Packages.ffpyplayer
  • python312Packages.ffpyplayer.dist
  • python312Packages.pycodec2
  • python312Packages.pycodec2.dist
  • python313Packages.ffpyplayer
  • python313Packages.ffpyplayer.dist
  • python313Packages.pycodec2
  • python313Packages.pycodec2.dist
  • sideband
  • sideband.dist

aarch64-linux

❌ 4 packages failed to build:
  • python312Packages.pyobjus
  • python312Packages.pyobjus.dist
  • python313Packages.pyobjus
  • python313Packages.pyobjus.dist
✅ 10 packages built:
  • python312Packages.ffpyplayer
  • python312Packages.ffpyplayer.dist
  • python312Packages.pycodec2
  • python312Packages.pycodec2.dist
  • python313Packages.ffpyplayer
  • python313Packages.ffpyplayer.dist
  • python313Packages.pycodec2
  • python313Packages.pycodec2.dist
  • sideband
  • sideband.dist

x86_64-darwin

❌ 4 packages failed to build:
  • python312Packages.pyobjus
  • python312Packages.pyobjus.dist
  • python313Packages.pyobjus
  • python313Packages.pyobjus.dist
✅ 8 packages built:
  • python312Packages.ffpyplayer
  • python312Packages.ffpyplayer.dist
  • python312Packages.pycodec2
  • python312Packages.pycodec2.dist
  • python313Packages.ffpyplayer
  • python313Packages.ffpyplayer.dist
  • python313Packages.pycodec2
  • python313Packages.pycodec2.dist

aarch64-darwin

❌ 4 packages failed to build:
  • python312Packages.pyobjus
  • python312Packages.pyobjus.dist
  • python313Packages.pyobjus
  • python313Packages.pyobjus.dist
✅ 8 packages built:
  • python312Packages.ffpyplayer
  • python312Packages.ffpyplayer.dist
  • python312Packages.pycodec2
  • python312Packages.pycodec2.dist
  • python313Packages.ffpyplayer
  • python313Packages.ffpyplayer.dist
  • python313Packages.pycodec2
  • python313Packages.pycodec2.dist

@adingbatponder
Copy link

It would be great to make this work.... thanks so much for the efforts.

@Erethon
Copy link
Contributor

Erethon commented Feb 10, 2025

Thank you for packaging sideband! A mini initial review:

  1. sideband -d works on NixOS as is!
  2. Running sideband with the UI enabled however currently fails. This is because .kv files that are needed for the app to work aren't included in the build. I'm not sure if this is because of some Nix sandboxing, but I've opened Fix kivy path in setup.py markqvist/Sideband#72 upstream to look further into it. Applying this patch via a patches fixes this and sideband with the UI loads fine.
  3. Kivy tries to find xclip or xsel, if you don't have any of these installed some errors get printed on the logs. Setting xclip/xsel as a dependency with this patch fixes this, but I'm not sure if this should be done on Sideband or on the Kivy package instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants