Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

19.09 zhf mark broken #70645

Merged
merged 2 commits into from
Oct 7, 2019
Merged

19.09 zhf mark broken #70645

merged 2 commits into from
Oct 7, 2019

Conversation

disassembler
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@disassembler disassembler changed the base branch from master to release-19.09 October 7, 2019 15:44
worldofpeace
worldofpeace reviewed Oct 7, 2019
View reviewed changes
pkgs/tools/security/sequoia/default.nix
@@ -87,5 +87,6 @@ rustPlatform.buildRustPackage rec {
license = licenses.gpl3;
maintainers = with maintainers; [ minijackson doronbehar ];
platforms = platforms.all;
broken = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please link #70646

jonringer
jonringer reviewed Oct 7, 2019
View reviewed changes
pkgs/applications/networking/znc/modules.nix Outdated
@@ -94,6 +94,7 @@ in {
description = "ZNC FiSH module";
homepage = https://github.com/dctrwatson/znc-fish;
maintainers = [ stdenv.lib.maintainers.offline ];
broken = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

znc backported fix cc25b7a

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, removed this broken-marking :)

pkgs/development/python-modules/cufflinks/default.nix Outdated
@@ -55,5 +55,6 @@ buildPythonPackage rec {
homepage = "https://github.com/santosjorge/cufflinks";
license = licenses.mit;
maintainers = with maintainers; [ globin ];
broken = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported fix f364b99

pkgs/development/python-modules/supervisor/default.nix
@@ -22,5 +22,6 @@ buildPythonPackage rec {
homepage = http://supervisord.org/;
license = licenses.free; # http://www.repoze.org/LICENSE.txt
maintainers = with maintainers; [ zimbatm ];
broken = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this package builds on the branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, i forgot to be backport #70073, nevermind

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should backport @jonringer 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll backport it on this branch

@jonringer
Copy link
Contributor

jonringer commented Oct 7, 2019 •
edited
Loading

@GrahamcOfBorg build python3Packages.cufflinks pythonPackages.cufflinks zncModules.fish

EDIT: oh yea, they won't build because they are already marked broken within the PR

@ofborg ofborg bot added 6.topic: emacs Text editor 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment labels Oct 7, 2019
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: emacs Text editor 6.topic: erlang 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: vim 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 7, 2019
@disassembler disassembler force-pushed the 19.09-zhf-mark-broken branch from bb284f5 to f68f0a8 Compare October 7, 2019 16:50
@disassembler disassembler merged commit e675498 into NixOS:release-19.09 Oct 7, 2019
@disassembler disassembler deleted the 19.09-zhf-mark-broken branch October 7, 2019 17:45
@srhb srhb mentioned this pull request Oct 8, 2019
Closed
@grahamc grahamc mentioned this pull request Oct 11, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann lheckemann left review comments

@jonringer jonringer jonringer left review comments

@worldofpeace worldofpeace worldofpeace left review comments

@alyssais alyssais Awaiting requested review from alyssais

@basvandijk basvandijk Awaiting requested review from basvandijk

@edolstra edolstra Awaiting requested review from edolstra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@infinisil infinisil Awaiting requested review from infinisil

@joachifm joachifm Awaiting requested review from joachifm

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

@peti peti Awaiting requested review from peti

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@WilliButz WilliButz Awaiting requested review from WilliButz

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: python 6.topic: qt/kde 6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@disassembler @jonringer @lheckemann @worldofpeace