Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequoia: 0.16.0 -> 0.17.0 #90591

Merged
merged 2 commits into from
Jul 12, 2020
Merged

sequoia: 0.16.0 -> 0.17.0 #90591

merged 2 commits into from
Jul 12, 2020

Conversation

puzzlewolf
Copy link
Contributor

Motivation for this change

sequoia version 0.17.0 has been released

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Ping maintainers: @minijackson, @doronbehar

@ofborg ofborg bot requested a review from doronbehar June 16, 2020 08:46
@doronbehar
Copy link
Contributor

Tests fail in CI.

@puzzlewolf
Copy link
Contributor Author

Hm, builds fine on my machine. I'll take a look at those tests.

@puzzlewolf
Copy link
Contributor Author

puzzlewolf commented Jun 16, 2020 •
edited
Loading

It runs out of file handles, so it's #70646 again. What does that mean? I can't find a solution in that issue, but somehow the build succeeded later. In #80209 @bhipple says about the same problem

I'm guessing it'll build eventually?

So, just wait and rebuild?

@minijackson
Copy link
Member

Yeah, it's unfortunate :-/

One thing we can try though, is to reduce the number of tests run in parallel by overriding the check phase, and setting the --jobs option in cargo test.

@puzzlewolf
sequoia: exclude tests for 'sequoia-store'
c26c77b 
Tests for 'sequoia-store' often error with 'Too many open filehandles'
on ofBorg and Hydra. Exclude them until a better solution
can be found.
@puzzlewolf
Copy link
Contributor Author

Let's see if deactivating the 'sequoia-store' tests does the trick :D

@puzzlewolf
Copy link
Contributor Author

So, I noticed (in the log posted in #70646 and the failed build here) that the failing tests are all for the sequoia-store package. I guess it's better to deactivate those specific tests than to slow them all down by limiting the number of jobs.
All tests are run by upstream CI anyway, I guess we can live without a couple ones that prove problematic for our environment. What do you think?

@doronbehar
Copy link
Contributor

@GrahamcOfBorg's environment is not exactly as hydra, but still, the idea sounds good to me.

@puzzlewolf
Copy link
Contributor Author

We won't know if it works on Hydra until it has been built there 😆. I'm not too familiar with how Hydra works, but I guess we'll have to merge this, right?

@minijackson minijackson mentioned this pull request Jul 7, 2020
Closed
@doronbehar doronbehar mentioned this pull request Jul 11, 2020
Closed
@erictapen
Copy link
Member

I agree, let's merge this.

@erictapen erictapen merged commit c2bacaf into NixOS:master Jul 12, 2020
@puzzlewolf puzzlewolf deleted the sequoia_0.17 branch August 10, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@puzzlewolf @doronbehar @minijackson @erictapen