Regularizar dependencias npm #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cristofer-dev Tu tienes permisos para aprobar este pr? |
|
@enBonnet todos deberiamos tener! Sólo deben ir a Revisar los cambios y luego en: Aprobar o Solicitar cambios. Para llegar a Master necesitas al menos que 1 apruebe los cambios. De momento nadie a hecho el review por eso el merge esta bloqueado. |
|
Ha si... y el DEPLOY a netlify fallo, asi es que es probable que tambien falle en PROD ? |
uhm, por eso será el bloqueo? Funciona en mi pc ahahahaah, voy a probar en otro equipo y te digo |
|
Ambas, el boqueo es por que nadie ha aprobado y xq explot el deploy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisé las dependencias mencionadas y practicamente todas tenían que ver con la versión de webpack que usa el paquete
preact-cli. Hice el push a mi fork, habilité el dependency graph y los insights y no me aparecieron alertas.Quedo atento a cualquier feedback ❤️