Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep scroll position in flatprofile view on repaint #267

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Sep 22, 2024

Closes #266

@DanielRuf DanielRuf changed the title Keep scroll position in flatprofile view on repaint - closes #266 Keep scroll position in flatprofile view on repaint Sep 22, 2024
@NoiseByNorthwest
Copy link
Owner

@DanielRuf LGTM, thanks 👍

Side note: the text is still unselected on repaint, but things are way better with your patch.

@NoiseByNorthwest NoiseByNorthwest merged commit 73c16fc into NoiseByNorthwest:master Sep 22, 2024
37 checks passed
@DanielRuf DanielRuf deleted the feature/266-flatprofile-keep-scroll-position branch September 23, 2024 05:39
@DanielRuf
Copy link
Contributor Author

Side note: the text is still unselected on repaint

I will check this.

@DanielRuf
Copy link
Contributor Author

When I click in the timeline view, the selected text on the left side is still selected:

image

@NoiseByNorthwest is this logic correct or should it automatically clear the selection on click in the timeline view at the top?

A simple "remove text selection" logic would be window.getSelection().removeAllRanges().

@NoiseByNorthwest
Copy link
Owner

NoiseByNorthwest commented Sep 23, 2024

When I click in the timeline view, the selected text on the left side is still selected:

I don't reproduce it, where do you click ? If I click on a span it makes that span selected (thus clearing the previously selected span info), if I click elsewhere (not on a span) it clears the overlay with the focus/selected span information...

@DanielRuf
Copy link
Contributor Author

DanielRuf commented Sep 23, 2024

I mean visually selected, the text itself changes here in Microsoft Edge.

Maybe creating a separate issue with the right steps to reproduce might be helpful. Otherwise if this is not a big issue and will be solved with the UI rewrite, it might be not relevant at the moment.

@NoiseByNorthwest
Copy link
Owner

Maybe creating a separate issue with the right steps to reproduce might be helpful.

Yes

Otherwise if this is not a big issue and will be solved with the UI rrwrite, it might be not relevant at the moment.

Maybe, I let you decide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

highlighting a function in the flat profile jumps to the top of the list
2 participants