Skip to content

Commit

Permalink
fix: provide implicitly required context for the hook manager
Browse files Browse the repository at this point in the history
  • Loading branch information
galargh committed Jan 29, 2025
1 parent 135d975 commit 3ed8587
Showing 1 changed file with 10 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {

import { SolidityBuildSystemImplementation } from "../../../../../src/internal/builtin-plugins/solidity/build-system/build-system.js";
import { HookManagerImplementation } from "../../../../../src/internal/core/hook-manager.js";
import { HookContext } from "../../../../../src/types/hooks.js";

async function emitArtifacts(solidity: SolidityBuildSystem): Promise<void> {
const rootFilePaths = await solidity.getRootFilePaths();
Expand All @@ -47,7 +48,7 @@ async function emitArtifacts(solidity: SolidityBuildSystem): Promise<void> {
}

// NOTE: This test is slow because solidity compilers are downloaded.
describe(
describe.only(
"SolidityBuildSystemImplementation",
{
skip: process.env.HARDHAT_DISABLE_SLOW_TESTS === "true",
Expand Down Expand Up @@ -86,8 +87,11 @@ describe(
expectedCachePath = path.join(process.cwd(), "cache");
await remove(expectedArtifactsPath);
await remove(expectedCachePath);
const hooks = new HookManagerImplementation(process.cwd(), []);
// eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- We don't care about hooks in this context
hooks.setContext({} as HookContext);
solidity = new SolidityBuildSystemImplementation(
new HookManagerImplementation(process.cwd(), []),
hooks,
{
solidityConfig,
projectRoot: process.cwd(),
Expand All @@ -108,8 +112,11 @@ describe(
const tmpDir = await getTmpDir("solidity-build-system-implementation");
actualArtifactsPath = path.join(tmpDir, "artifacts");
actualCachePath = path.join(tmpDir, "cache");
const hooks = new HookManagerImplementation(process.cwd(), []);
// eslint-disable-next-line @typescript-eslint/consistent-type-assertions -- We don't care about hooks in this context
hooks.setContext({} as HookContext);
solidity = new SolidityBuildSystemImplementation(
new HookManagerImplementation(process.cwd(), []),
hooks,
{
solidityConfig,
projectRoot: process.cwd(),
Expand Down

0 comments on commit 3ed8587

Please sign in to comment.