Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: interval mining #4619

Merged
merged 2 commits into from
Nov 27, 2023
Merged

feat: interval mining #4619

merged 2 commits into from
Nov 27, 2023

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Nov 24, 2023

Addresses review comments from @fvictorio, implementing the interval miner in the process

@Wodann Wodann self-assigned this Nov 24, 2023
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0eea705

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 3:00pm

agostbiro
agostbiro requested changes Nov 27, 2023
View reviewed changes
crates/edr_provider/src/data.rs Show resolved Hide resolved
crates/edr_provider/src/interval.rs Outdated Show resolved Hide resolved
@Wodann Wodann requested a review from agostbiro November 27, 2023 15:11
agostbiro
agostbiro approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@agostbiro agostbiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@Wodann Wodann merged commit 9e09fa1 into edr/main Nov 27, 2023
102 checks passed
@Wodann Wodann deleted the edr/refactor/code-review branch November 27, 2023 18:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agostbiro agostbiro agostbiro approved these changes

@fvictorio fvictorio Awaiting requested review from fvictorio

Assignees

@Wodann Wodann

Labels
area:edr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wodann @agostbiro