Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement auto-mining #4622

Merged
merged 34 commits into from
Dec 6, 2023
Merged

feat: implement auto-mining #4622

merged 34 commits into from
Dec 6, 2023

Conversation

Wodann
Copy link
Member

@Wodann Wodann commented Nov 24, 2023

No description provided.

@Wodann Wodann self-assigned this Nov 24, 2023
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 15e9ff0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 9:51am

@Wodann Wodann changed the title Edr/feat/send transaction feat: implement auto-mining Nov 24, 2023
@Wodann Wodann force-pushed the edr/feat/send-transaction branch from a9745f4 to c50a9d7 Compare December 6, 2023 01:29
Wodann
Wodann commented Dec 6, 2023
View reviewed changes
...s/hardhat-core/test/internal/hardhat-network/provider/modules/eth/methods/sendTransaction.ts
@@ -1108,6 +1108,8 @@ describe("Eth module", function () {
);
}

const chainId = await this.provider.send("eth_chainId");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fvictorio & @alcuadrado, the test was using the chainId specified in the provider config, but for a forked provider, we set it based on the remote's chain ID.

I just wanted to validate whether the fix follows the spirit of the original test?

Wodann
Wodann commented Dec 6, 2023
View reviewed changes
crates/edr_provider/src/data.rs
@@ -688,6 +688,14 @@ impl ProviderData {
}
}

while self.mem_pool.has_pending_transactions() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fvictorio & @alcuadrado, I noticed that this part was lost in the port. Just checking; do we actually need to mine all pending transactions?

@Wodann Wodann force-pushed the edr/feat/send-transaction branch from 821d03d to d3e33a2 Compare December 6, 2023 02:25
@Wodann Wodann requested a review from alcuadrado December 6, 2023 02:26
This was linked to issues Dec 6, 2023
Port mempool transaction RPC methods NomicFoundation/edr#215
Closed
Port hardhat_setMinGasPrice NomicFoundation/edr#135
Closed
Port eth_call from Hardhat NomicFoundation/edr#214
Closed
agostbiro
agostbiro reviewed Dec 6, 2023
View reviewed changes
crates/edr_evm/src/mempool.rs Show resolved Hide resolved
crates/edr_provider/src/data.rs Show resolved Hide resolved
crates/edr_provider/src/data.rs Show resolved Hide resolved
@agostbiro agostbiro force-pushed the edr/feat/send-transaction branch from 8d80fef to 15e9ff0 Compare December 6, 2023 09:51
@agostbiro agostbiro self-requested a review December 6, 2023 14:48
@Wodann Wodann merged commit 8debd54 into edr/main Dec 6, 2023
201 of 202 checks passed
@Wodann Wodann deleted the edr/feat/send-transaction branch December 6, 2023 16:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agostbiro agostbiro agostbiro approved these changes

@fvictorio fvictorio Awaiting requested review from fvictorio

@alcuadrado alcuadrado Awaiting requested review from alcuadrado

Assignees

@Wodann Wodann

Labels
area:edr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port mempool transaction RPC methods Port eth_call from Hardhat Port hardhat_setMinGasPrice
3 participants
@Wodann @alcuadrado @agostbiro