Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix typo in function name check-dependencies.js #6080

Closed
wants to merge 1 commit into from

Conversation

mdqst
Copy link

@mdqst mdqst commented Dec 26, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

Hi team,

I noticed a typo in the function name checkPeerDepedencies — it should be checkPeerDependencies.

This update renames the function to ensure correctness and better readability.

Changes include:

  • Renaming the function from checkPeerDepedencies to checkPeerDependencies.
  • Updating all relevant references in the codebase to use the corrected name.

Thanks!

Copy link

changeset-bot bot commented Dec 26, 2024

⚠️ No Changeset found

Latest commit: 80cf472

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 4:32pm

@schaable
Copy link
Member

Hi @mdqst, thanks for submitting a PR! This typo has already been addressed in #6078, so I’ll be closing this one.

@schaable schaable closed this Dec 26, 2024
@mdqst
Copy link
Author

mdqst commented Dec 26, 2024

#6078

schaable, yes, but in that pull request, the person didn’t fix the issue, whereas I did, and now the script works correctly.

@mdqst mdqst deleted the patch-1 branch January 3, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants