-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Network manager tests #6201
Network manager tests #6201
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
v-next/hardhat/src/internal/builtin-plugins/network-manager/provider-errors.ts
Show resolved
Hide resolved
v-next/hardhat/test/internal/builtin-plugins/network-manager/http-provider.ts
Outdated
Show resolved
Hide resolved
v-next/hardhat/test/internal/builtin-plugins/network-manager/config-resolution.ts
Show resolved
Hide resolved
v-next/hardhat/test/internal/builtin-plugins/network-manager/config-resolution.ts
Show resolved
Hide resolved
v-next/hardhat/test/internal/builtin-plugins/network-manager/edr/edr-provider.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few minor comments but a part from that LGTM 😎
The PR adds tests to the network manager, specifically for the config resolution phase and providers. It also fixes a bug in
edrRpcDebugTraceToHardhat
, where theoutput
was mistakenly treated as aBuffer
instead of astring
(due to an incorrect type from EDR). Finally, it groups theProviderError
s into a single file and normalizes their constructors.Follow-up issues: