-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up for classification by refactoring solution interface #133
Conversation
fd66681
to
686c8e0
Compare
Oeoeo 3x speedup is already very nice! I will review the code today. |
i don't see the bug. I think it is better you do it. |
I'm not seeing this, for example with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a major improvement! Very nice!
One quick question. What is the idea about batching the threading instead of just using @threads
macro of all indices over the solution matrix?
Before you Tag the master branch to the Julia register, we could also merge the method keyword from branch |
get_single_solution
is supposed to be a user-friendly method but is terribly inefficient for internal work, which has been an issue before (#86 , #130 ) . Rather, we want to pass vectors of variables + varied parameters around, in a fixed order.Here:
OrderedDict
removed (still works as a UI method)OrderedDict
and a vector of variables + varied parameterstransform_solutions
_classify_default
for 1000 solutions of 9 branches, before:after: