Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal symbolic clean up #268

Merged
merged 19 commits into from
Oct 13, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make some modifications to extentension code quality tests
  • Loading branch information
oameye committed Oct 13, 2024
commit d5fd4e4e49445b9189c6ad872b0d2a635bde8c77
2 changes: 1 addition & 1 deletion ext/SteadyStateDiffEqExt.jl
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ using HarmonicBalance: HarmonicBalance, steady_state_sweep

using SteadyStateDiffEq: solve, NonlinearProblem, SteadyStateProblem, DynamicSS, remake
using LinearAlgebra: norm, eigvals
using SteadyStateDiffEq.SciMLBase.SciMLStructures: isscimlstructure, Tunable, replace
using SteadyStateDiffEq.SciMLBase.SciMLStructures: Tunable, replace

function HarmonicBalance.steady_state_sweep(
prob::SteadyStateProblem, alg::DynamicSS; varied::Pair, kwargs...
Expand Down
5 changes: 2 additions & 3 deletions ext/TimeEvolution/TimeEvolution.jl
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,9 @@ include("ODEProblem.jl")
include("hysteresis_sweep.jl")
include("plotting.jl")

export FFT
export ParameterSweep
export transform_solutions, plot, plot!, is_stable
export transform_solutions, plot, plot!
export ODEProblem, solve
export plot_1D_solutions_branch, follow_branch
export follow_branch

end
19 changes: 14 additions & 5 deletions test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,27 @@ Random.seed!(SEED)
ModelingToolkitExt = Base.get_extension(HarmonicBalance, :ModelingToolkitExt)
SteadyStateDiffEqExt = Base.get_extension(HarmonicBalance, :SteadyStateDiffEqExt)

@test check_no_stale_explicit_imports(HarmonicBalance) == nothing
@test check_all_explicit_imports_via_owners(HarmonicBalance) == nothing
Aqua.test_ambiguities(HarmonicBalance)
Aqua.test_all(
HarmonicBalance;
deps_compat=(
ignore=ignore_deps,
check_extras=(ignore=ignore_deps,),
check_weakdeps=(ignore=ignore_deps,),
),
ambiguities=false,
)
for mod in [HarmonicBalance, TimeEvolution, ModelingToolkitExt, SteadyStateDiffEqExt]
@test check_no_stale_explicit_imports(mod) == nothing
@test check_all_explicit_imports_via_owners(mod) == nothing
Aqua.test_ambiguities(mod)
Aqua.test_all(
mod;
deps_compat=(
ignore=ignore_deps,
check_extras=(ignore=ignore_deps,),
check_weakdeps=(ignore=ignore_deps,),
),
deps_compat=false,
ambiguities=false,
piracies=false,
)
end
end
Expand Down
Loading