Fix Ncycle #496
Merged
Fix Ncycle #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaerz
added
bug
JorgSchwinger
approved these changes
Feb 14, 2025
TomasTorsvik
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @JorgSchwinger and @TomasTorsvik ,
this PR is an immediate fix for #479. Noticeably, at least in my simulations, the issue was only indirectly related to
lkwrbioz_off=.true.- it somehow led to zero oxygen values in the sediment that then led to division by zero, which I fixed now (also for the water column for safety). I ran a previously crashing simulation for one month in DEBUG mode ontnx2and it ran through with this fix. Maybe @JorgSchwinger , you could do a short run with your setup to see, if it this fixes thelkwrbioz_off=.true.issue reported in #479?I will investigate one more thing that I stumbled upon (which may or may not lead to changes), but I think an incremental PR approach is better in this case.
Closes #479