-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLT-5866: Remove app_user_uid from the config. #1023
Conversation
deb220f
to
488ab7e
Compare
+1 |
488ab7e
to
6f0f702
Compare
6f0f702
to
1c79a2d
Compare
What is the difference between |
1c79a2d
to
8c3f6ca
Compare
8c3f6ca
to
0b5a266
Compare
@Hasan6979 One is used to identify the device on meshnet, and the other to identify the device for MQTT subscriptions.
|
0b5a266
to
30fd1fe
Compare
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.0
Problem
Currently
app_user_id
used for notification center is part of the user provided config for teliod. It shouldn’t be user configurable, we can reuse the the meshnethardware_id
for it instead which should be generated when the device is registered.Solution
Remove
app_user_uid
from the user config.Use a randomly generated UUID instead of the public key for
hw_identifier
.Use the
hw_identifier
asapp_user_uid
in notification center.☑️ Definition of Done checklist