Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLT-5866: Remove app_user_uid from the config. #1023

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

tomasz-grz
Copy link
Contributor

@tomasz-grz tomasz-grz commented Dec 12, 2024

Problem

Currently app_user_id used for notification center is part of the user provided config for teliod. It shouldn’t be user configurable, we can reuse the the meshnet hardware_id for it instead which should be generated when the device is registered.

Solution

Remove app_user_uid from the user config.
Use a randomly generated UUID instead of the public key for hw_identifier.
Use the hw_identifier as app_user_uid in notification center.

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@tomasz-grz tomasz-grz self-assigned this Dec 12, 2024
@tomasz-grz tomasz-grz marked this pull request as ready for review December 12, 2024 13:50
@tomasz-grz tomasz-grz requested a review from a team as a code owner December 12, 2024 13:50
clis/teliod/src/nc.rs Outdated Show resolved Hide resolved
@matislovas
Copy link
Collaborator

+1

@Hasan6979
Copy link
Contributor

What is the difference between app_user_id and hw_identifier ?
From what I understand is that, one is more device specific, and the other is user specific right ? 1 user can have many devices.

@tomasz-grz
Copy link
Contributor Author

tomasz-grz commented Dec 18, 2024

@Hasan6979 One is used to identify the device on meshnet, and the other to identify the device for MQTT subscriptions.

The parameter app_user_uid has to be an identifier that is unique per device and user. Meaning that it should be different for the same user on different device.

@Hasan6979
Copy link
Contributor

+1

Copy link
Collaborator

@packgron packgron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.0

@tomasz-grz tomasz-grz merged commit 554b1b4 into main Jan 6, 2025
64 checks passed
@tomasz-grz tomasz-grz deleted the teliod_uid branch January 6, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants