Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the VMs can ping each other #1032

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

tomaszklak
Copy link
Contributor

@tomaszklak tomaszklak commented Dec 17, 2024

Problem

There is no point in running tests when networking is broken

Solution

Check that VMs can reach each other, and also at least one selected docker host.

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@tomaszklak tomaszklak requested a review from a team as a code owner December 17, 2024 11:49
Copy link
Collaborator

@jjanowsk jjanowsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

LukasPukenis
LukasPukenis previously approved these changes Dec 18, 2024
Copy link
Contributor

@LukasPukenis LukasPukenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

nat-lab/tests/conftest.py Outdated Show resolved Hide resolved
Also one selected node from docker is checked
@tomaszklak tomaszklak force-pushed the connectivity-check-in-nat-lab branch from afa0818 to 3412f7a Compare December 19, 2024 12:23
@tomaszklak tomaszklak merged commit 0d420fc into main Dec 19, 2024
64 checks passed
@tomaszklak tomaszklak deleted the connectivity-check-in-nat-lab branch December 19, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants