Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FiveTuple printing #1034

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Fix FiveTuple printing #1034

merged 1 commit into from
Dec 18, 2024

Conversation

Jauler
Copy link
Contributor

@Jauler Jauler commented Dec 17, 2024

Problem

FiveTuple from connection tracker, when printed would produce the following output:

In nlx_1 there has been 3 connections to <class 'utils.connection_tracker.FiveTuple'> which is more then max limit of 2

Obviously <class 'utils.connection_Tracker.FiveTuple> is not desirable, hence this PR adds def __str__ implementation to the class.

This is the result:
2024-12-17_17-20-44_grim

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@Jauler Jauler requested a review from a team as a code owner December 17, 2024 15:24
@mathiaspeters
Copy link
Contributor

Tiny sorta-unrelated nit/request: Can we change In nlx_1 there has been 3 connections to <class 'utils.connection_tracker.FiveTuple'> which is more then max limit of 2 so that it says than instead of then. #sorrynotsorry

@Jauler Jauler force-pushed the Fix_fivetuple_printing_in_conntracker branch from 344ade5 to c9dfea7 Compare December 17, 2024 15:33
@Jauler
Copy link
Contributor Author

Jauler commented Dec 17, 2024

Tiny sorta-unrelated nit/request: Can we change In nlx_1 there has been 3 connections to <class 'utils.connection_tracker.FiveTuple'> which is more then max limit of 2 so that it says than instead of then. #sorrynotsorry

nice catch. Fixed.

@Jauler Jauler force-pushed the Fix_fivetuple_printing_in_conntracker branch from c9dfea7 to 37f1712 Compare December 17, 2024 15:34
Copy link
Contributor

@mathiaspeters mathiaspeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+2

@Jauler Jauler enabled auto-merge December 17, 2024 16:21
@Jauler Jauler merged commit 237d70f into main Dec 18, 2024
64 checks passed
@Jauler Jauler deleted the Fix_fivetuple_printing_in_conntracker branch December 18, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants