Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp in logs (also) on libtelio side #1035

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

tomaszklak
Copy link
Contributor

@tomaszklak tomaszklak commented Dec 17, 2024

By default timestamp are not added, but tests-like environments might want to add timestamps on libtelio side.

This is enabeld for nat-lab / libtelio-remote tests.

☑️ Definition of Done checklist

  • Commit history is clean (requirements)
  • README.md is updated
  • Functionality is covered by unit or integration tests

@tomaszklak tomaszklak requested a review from a team as a code owner December 17, 2024 16:01
Copy link
Contributor

@LukasPukenis LukasPukenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice +1

src/ffi/logging.rs Show resolved Hide resolved
@dfetti dfetti self-requested a review December 18, 2024 10:26
Copy link
Contributor

@dfetti dfetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.0

By default timestamp are not added, but tests-like environments might
want to add timestamps on libtelio side.

This is enabeld for nat-lab / libtelio-remote tests
@tomaszklak tomaszklak merged commit 6f2e392 into main Dec 18, 2024
63 checks passed
@tomaszklak tomaszklak deleted the log_time_in_telio branch December 18, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants