Make sure that build scripts use rerun-if-changed in a correct way #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszklak
force-pushed
the
tk-no-needless-rebuilds-in-nat-lab
branch
from
fb55746 to
003ddbb
Compare
For lana, this script is self contained so it should explicitly depend only on itself. For toplevel, we don't need to check changes in crates and src if the bypass is in place.
tomaszklak
force-pushed
the
tk-no-needless-rebuilds-in-nat-lab
branch
from
003ddbb to
4a4d8ca
Compare
LukasPukenis
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For lana, this script is self contained so it should explicitly depend only on itself. For toplevel, we don't need to check changes in crates and src if the bypass is in place.
After this change, subsequent invocations of
run_local.pyorbuild.sh, will not rebuild/relink anything if there are no changes.☑️ Definition of Done checklist