[LLT-4202] Make lookup return error in case of failure on forward #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfetti
force-pushed
the
LLT-4202-return-error-if-forward-fails
branch
from
77d0fae to
f9c2ba7
Compare
dfetti
force-pushed
the
LLT-4202-return-error-if-forward-fails
branch
3 times, most recently
from
ffcddd5 to
03e6c3c
Compare
|
+1 |
|
The commented out workflows should be commented why they're commented out and if there's isn't already there should be a ticket to fix it, or an issue opened upstream that can be linked in the aforementioned comment. It might make sense to add the comment both in the code and in the commit message |
|
The commit message should also explain why we want to make lookup return error in case of failure on forward. |
tomaszklak
reviewed
Nov 13, 2023
Make the forward error visible instead of just filling the response buffer with an empty response. The inieal problem was that if the forward lookup from trust-dns fails, the failure is not indicated to libtelio. Instead the response buffer was filled with an empty lookup response. This, combined with the doubled retry mechanis (OS and trust-dns) produced some issues on IOS. This commit also removes the compatibility checks from the workflows. It started to fail after the version update. I created LLT-4544 to fix it.
dfetti
force-pushed
the
LLT-4202-return-error-if-forward-fails
branch
from
03e6c3c to
c87d453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the forward error visible instead of just filling the response buffer with an empty response.