Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/recover on crash #487

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Feat/recover on crash #487

wants to merge 25 commits into from

Conversation

tsvetelinpetrov
Copy link
Contributor

No description provided.

@tsvetelinpetrov tsvetelinpetrov added doc required This PR includes user-facing changes that need to be documented. ui not required All PRs either need "ui required" or "ui not required". labels Jan 27, 2025
Copy link
Contributor

@kylebonnici kylebonnici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work very clean and organised 🥇

One minot change is needed in my opinion to the recovery that is we should use macro task and not Microtasks other that that all good :)

Share some UI videos so @ketile can see and do not forget to update the change log

src/features/recovery/RecoveryManager.ts Outdated Show resolved Hide resolved
src/features/recovery/RecoveryManager.ts Show resolved Hide resolved
src/features/recovery/RecoveryManager.ts Outdated Show resolved Hide resolved
@kylebonnici kylebonnici added ui required All PRs either need "ui required" or "ui not required". and removed ui not required All PRs either need "ui required" or "ui not required". labels Feb 4, 2025
@tsvetelinpetrov
Copy link
Contributor Author

tsvetelinpetrov commented Feb 4, 2025

@ketile

image

image

image

image

image

image

image

image

image

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc required This PR includes user-facing changes that need to be documented. ui required All PRs either need "ui required" or "ui not required".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants