Add Valkey support to the build and to the compatibility test in CI #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shall we leave this open until the next release candidate, or the actual release, is out? |
|
I guess you know best how far away an actual release is, and I've seen talks about possibly changing which patch-version to use. |
|
ok, do as you want. the release is within a week. |
Adds the CMake option TEST_WITH_VALKEY_VERSION to enable `make start` to setup a Valkey Cluster. The default behaviour, when the option is not set, is to run tests with Redis. A given Valkey version takes precedence. Example usage: mkdir build && cd build cmake -DTEST_WITH_VALKEY_VERSION=7.2.5 .. make start make test make stop
|
Updated to run on the first stable release of Valkey |
zuiderkwast
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the CMake option
TEST_WITH_VALKEY_VERSIONto enablemake startto setup Valkey clusters instead of Redis.The default behavior, when the option is not set, is to run tests with Redis, but a given Valkey version takes precedence.
(Note: There is already an option to specify a Redis version
TEST_WITH_REDIS_VERSIONand Redis6.2.1is the default.)Example usage:
Additionallty adds Valkey
7.2.5to the compatibility test in CI.