Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove machine id in ubuntu images #689

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sunnatillo
Copy link
Member

@Sunnatillo Sunnatillo commented Jul 29, 2023

Copy of #675, #675 could not be tested due to CI constraints.
Authored by @jklippel

"Currently the image contains an id in /etc/machine-id. This file should contain a unique machine ID which uniquely identifies the host (see machine-id(5)).
Some processes rely on this file to generate other values e.g. mac-addresses on bond interfaces.
If the machine-id is the same accross many hosts
these mac-addresses will under certain circumstances be generated identically. Two hosts having the same mac address leads to L2-networking issues.

This commit empties the machine-id file so that it is regenerated on the next boot (which will be the first boot of the machine the image is used for)."

@metal3-io-bot
Copy link
Member

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sunnatillo. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sunnatillo Sunnatillo changed the title remove machine id to generate different mac address in first boot remove machine id to generate different mac address Jul 29, 2023
@Sunnatillo
Copy link
Member Author

/test-integration-metal3-dev-tools-centos
/test-integration-metal3-dev-tools-ubuntu

@Sunnatillo Sunnatillo changed the title remove machine id to generate different mac address remove machine id Jul 29, 2023
@Sunnatillo Sunnatillo changed the title remove machine id remove machine id in ubuntu images Jul 29, 2023
@Sunnatillo
Copy link
Member Author

/test-integration-metal3-dev-tools-ubuntu

1 similar comment
@Sunnatillo
Copy link
Member Author

/test-integration-metal3-dev-tools-ubuntu

@Sunnatillo
Copy link
Member Author

/test-integration-metal3-dev-tools-centos
/test-integration-metal3-dev-tools-ubuntu

@mquhuy
Copy link
Member

mquhuy commented Oct 25, 2023

/test-integration-metal3-dev-tools-ubuntu

@metal3-io-bot
Copy link
Member

@Sunnatillo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
markdownlint 3f3d4d7 link true /test markdownlint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@metal3-io-bot
Copy link
Member

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants