Fixes #25936: Port condition_from methods to log v4+ #1438
+91
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
Fdall
force-pushed
the
ust_25936/port_condition_from_methods_to_log_v4
branch
from
5233811
to
c59489a
Compare
Fixes #25936: Port condition_from methods to log v4+
|
PR updated with a new commit |
amousset
reviewed
Nov 22, 2024
| @@ -84,13 +80,11 @@ bundle agent condition_from_expression(condition, expression) | |||
| scope => "namespace"; | |||
|
|
|||
| methods: | |||
| "success" usebundle => _classes_success("${old_class_prefix}"); | |||
| "success" usebundle => _classes_success("${report_data.method_id}"); | |||
There was a problem hiding this comment.
Suggested change
| "success" usebundle => _classes_success("${report_data.method_id}"); | |
| "${report_data.method_id}" usebundle => _classes_success("${report_data.method_id}"); |
for consistency I think we should always use it is promiser for methods.
Fixes #25936: Port condition_from methods to log v4+
|
PR updated with a new commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/25936