Fixes #24872: Rework api authorization models #5669
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinceMacBuche
added
the
WIP
VinceMacBuche
removed
the
WIP
|
Commit modified |
VinceMacBuche
force-pushed
the
arch_24872/rework_api_authorization_models
branch
from
16e81d3
to
7703cc9
Compare
|
Commit modified |
VinceMacBuche
force-pushed
the
arch_24872/rework_api_authorization_models
branch
from
7703cc9
to
56e1117
Compare
fanf
reviewed
May 17, 2024
There was a problem hiding this comment.
OK, seems great. I think it needs at least a third pair of eyes to match the API dispatching - cc @clarkenciel perhaps?
| @@ -226,8 +226,8 @@ trait EndpointSchema { | |||
| // data container name: the expected object key in answer | |||
| def dataContainer: Option[String] | |||
|
|
|||
| // any authorization that allows to access that API - by default, admin.write | |||
| def authz: List[AuthorizationType] = List(AuthorizationType.Administration.Write) | |||
| // any authorization that allows to access that API | |||
There was a problem hiding this comment.
Perhaps add "Nil mean special any_righs, ie admin role, is needed"
clarktsiory
reviewed
Jun 13, 2024
| } | ||
| case object DeleteCampaignEvent extends CampaignApi with OneParam with StartsAtVersion16 with SortIndex { | ||
| val z: Int = implicitly[Line].value | ||
| val description = "Delete a campaign event" | ||
| val (action, path) = DELETE / "campaigns" / "events" / "{id}" | ||
| val dataContainer: Option[String] = None | ||
| val dataContainer: Option[String] = None | ||
| val authz: List[AuthorizationType] = AuthorizationType.Configuration.Read :: Nil |
There was a problem hiding this comment.
DeleteCampaignEvent here should require Write
Comment on lines
278
to
283
| case object ReloadGroup extends GroupApi with GeneralApi with OneParam with StartsAtVersion2 with SortIndex { | ||
| val z: Int = implicitly[Line].value | ||
| val description = "Update given dynamic group node list" | ||
| val (action, path) = GET / "groups" / "{id}" / "reload" | ||
| val authz: List[AuthorizationType] = AuthorizationType.Group.Read :: Nil | ||
| } |
There was a problem hiding this comment.
It could change the list of nodes in the group, so is it safe with Read instead of Write + Edit ?
Comment on lines
801
to
806
| case object CheckTechnique extends TechniqueApiPub with ZeroParam with StartsAtVersion16 with SortIndex { | ||
| val z: Int = implicitly[Line].value | ||
| val description = "Check if a techniques is valid yaml, with rudderc compilation, with various output (json ? yaml ?)" | ||
| val (action, path) = POST / "techniques" / "check" | ||
| val authz: List[AuthorizationType] = AuthorizationType.Technique.Write :: AuthorizationType.Technique.Edit :: Nil | ||
| } |
There was a problem hiding this comment.
I'm not sure if it's just a check (in which case maybe it should be Read), or it does something else behind...
I saw it being used in Elm technique editor, shouldn't we allow them to just check the yaml ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24872