Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25156: rudder-package fails to parse old plugin version numbers, breaking the upgrade #5773

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Fixes #25156: rudder-package fails to parse old plugin version numbers, breaking the upgrade #5773

merged 3 commits into from
Dec 9, 2024

Conversation

amousset
Copy link
Member

@amousset amousset requested a review from Fdall July 18, 2024 12:24
@amousset
Copy link
Member Author

PR updated with a new commit

@amousset amousset force-pushed the bug_25156/rudder_package_fails_to_parse_old_plugin_version_numbers_breaking_the_upgrade branch from 1c352a0 to 278e7ac Compare December 9, 2024 09:18
@amousset
Copy link
Member Author

amousset commented Dec 9, 2024

PR updated with a new commit

@amousset amousset force-pushed the bug_25156/rudder_package_fails_to_parse_old_plugin_version_numbers_breaking_the_upgrade branch from 278e7ac to 6d22c5f Compare December 9, 2024 09:20
@amousset
Copy link
Member Author

amousset commented Dec 9, 2024

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder/pull/5773
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/94134/console)

@amousset
Copy link
Member Author

amousset commented Dec 9, 2024

OK, squash merging this PR

@amousset
Fixes #25156: rudder-package fails to parse old plugin version number…
5f8652c 
…s, breaking the upgrade
@amousset
fixup! Work in progress
00223f7 
Fixes #25156: rudder-package fails to parse old plugin version numbers, breaking the upgrade
@amousset
fixup! fixup! Work in progress
7ef22eb 
Fixes #25156: rudder-package fails to parse old plugin version numbers, breaking the upgrade
@amousset amousset force-pushed the bug_25156/rudder_package_fails_to_parse_old_plugin_version_numbers_breaking_the_upgrade branch from 457d734 to 7ef22eb Compare December 9, 2024 10:09
@amousset amousset merged commit 7ef22eb into Normation:branches/rudder/8.1 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fdall Fdall Fdall approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amousset @Normation-Quality-Assistant @Fdall