Fixes #25842: scoreService and scoreServiceManager are not initialized where they should #6007
+31
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d where they should
…tialized where they should Fixes #25842: scoreService and scoreServiceManager are not initialized where they should
|
PR updated with a new commit |
…not initialized where they should Fixes #25842: scoreService and scoreServiceManager are not initialized where they should
|
PR updated with a new commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/25842
General ideas and hypothesis:
runNow(each one create more risk that there is a chain of.runNow/.attemp/.runNowwith the potential for deadlock)I added a (mutable) buffer in our
def initmethod, into which we can add ZIO effect related to services init, andrunNowit (in parallel, effect result discarded) at the end of the method.I used the same construct for post-plugin init.