Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25887: Migrate from lift-json to zio-json in LDAPEntityMapper #6023

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Fixes #25887: Migrate from lift-json to zio-json in LDAPEntityMapper #6023

merged 1 commit into from
Nov 25, 2024

Conversation

fanf
Copy link
Member

@fanf fanf commented Nov 17, 2024 •
edited
Loading

https://issues.rudder.io/issues/25887

Cleaning up LDAPEntityMapper from lift-json.
These is 3 commit:

  • the first one is the most involved (nothing hard) and deal with AgentRunInfo. It has two aspect, either from/to LDAP or from/to ELM. I tried to make that clearer
  • HeartbeatConfiguration is trivial
  • AcceptationTime has nothing hard, it's just a map of fancy types.

@fanf fanf requested a review from clarktsiory November 17, 2024 21:41
clarktsiory
clarktsiory reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not sure about the "Elm" naming, maybe at least the name should be more generic ?

@fanf fanf force-pushed the arch_25887/migrate_from_lift_json_to_zio_json_in_ldapentitymapper branch 2 times, most recently from 92e7496 to 189f7e9 Compare November 23, 2024 17:45
@fanf fanf mentioned this pull request Nov 24, 2024
Merged
@clarktsiory
Copy link
Contributor

LGTM ! The new style is very idiomatic !
It can be merged (but rebased and squashed first !)

@fanf fanf force-pushed the arch_25887/migrate_from_lift_json_to_zio_json_in_ldapentitymapper branch from 189f7e9 to 0aa8e21 Compare November 25, 2024 10:16
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 0aa8e21 into Normation:master Nov 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarktsiory clarktsiory clarktsiory left review comments

Assignees
No one assigned
Labels
Ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanf @clarktsiory @Normation-Quality-Assistant