-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement get_inspector_pending_approvals #206
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @fishonamos All contract compiles successfully and all test cases pass successfully. |
The get inspector pending approvals functions should return list of lands that are pending approval for a specific inspector. |
I will implement that right away |
…ands that are pending approval
We will close this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement inspector pending approvals function with tests
Description
Added a new function
get_inspector_pending_approvals
to allow inspectors to view their pending land approvals filtered by date range. This enhancement helps inspectors better manage their workload by accessing only relevant pending approvals within specified time periods.Implementation Details
get_inspector_pending_approvals
function that takes start and end timestampsTests Added
test_get_inspector_pending_approvals_unauthorized
: Ensures unauthorized users cannot access pending approvalstest_get_inspector_pending_approvals_empty_range
: Verifies correct handling of empty date rangesTesting
All tests can be run using:
scarb test test_land_register
Note: Contract compiles successfully and all test cases pass successfully