Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspector lands function #243

Merged
merged 10 commits into from
Dec 14, 2024
Merged

Inspector lands function #243

merged 10 commits into from
Dec 14, 2024

Conversation

casweeney
Copy link
Contributor

Inspector Lands Function

  • Added inspector_lands() in ILandRegistry interface
  • FEAT: implemented inspector_lands() function
  • UPDATE: updated update_land() to accept land_status
  • MOD: modified LandUpdated event, added status
  • FIXES: fixed test errors due to update_land() modification
  • TEST: implemented test_inspector_lands()

Related Issues

Closes: #238

Type of Change

  • [-] 🐛 Bug fix or ⚙️ enhancement
  • [-] ✨ New feature or Chore (change with no new features or fixes)

Checklist (select as many as applicable)

  • [-] The code follows the style guidelines of this project.
  • [-] All new and existing tests pass.
  • [-] This pull request is ready to be merged and reviewed.

@fishonamos fishonamos self-requested a review December 14, 2024 16:20
@fishonamos
Copy link
Member

fishonamos commented Dec 14, 2024 •
edited
Loading

Looks good! reviewing..

@fishonamos fishonamos merged commit 0579b22 into NoshonNetworks:main Dec 14, 2024
1 check passed
@casweeney casweeney deleted the inspector-lands-function branch December 14, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fishonamos fishonamos fishonamos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

create inspector lands function
2 participants
@casweeney @fishonamos