landing page redirect #249
Open
+11,194
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed. My bad. |
|
Please add the issue number to the description. |
Solomonsolomonsolomon
requested changes
Dec 22, 2024
app/client/package-lock.json
Outdated
There was a problem hiding this comment.
please we use pnpm instead of npm for app/client.kindly revert
land-registry-backend/src/app.ts
Outdated
| @@ -8,7 +8,7 @@ import { config } from "./config"; | |||
| const app = express(); | |||
|
|
|||
| // Middleware | |||
| app.use(helmet()); | |||
| // app.use(helmet()); | |||
There was a problem hiding this comment.
i noticed you commented out this line. might i ask why?
landing_page/src/app/lib/axios.ts
Outdated
| @@ -1,7 +1,7 @@ | |||
| import axios from "axios"; | |||
|
|
|||
| export const api = axios.create({ | |||
| baseURL: process.env.NEXT_PUBLIC_API_URL, | |||
| baseURL: 'http://localhost:3000', | |||
There was a problem hiding this comment.
please dont hardcode the base url
package.json
Outdated
| @@ -2,6 +2,13 @@ | |||
| "dependencies": { | |||
| "@apibara/indexer": "^0.4.1", | |||
| "@apibara/protocol": "^0.4.9", | |||
| "dotenv": "^16.4.7", | |||
There was a problem hiding this comment.
you're installing packages in the wrong directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Information
Related Issues
Closes #242
Type of Change
Checklist (select as many as applicable)