Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update land id logic. #257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Birdmannn
Copy link

Detailed Information

--- Update in the land id creation returned from the smart contract's register_land after registering a new land parcel.

Related Issues

The target function returns a very long u256 integer. Assignment was to still make this random, but shorter.
Closes #235


Type of Change

  • [ -] 🐛 Bug fix / ⚙️ enhancement: Updated the land ID generation logic.
  • [ -] ✨ New feature or Chore: Re-wrote the function, modified its implementation to ensure absolute uniqueness between all generated id. Halved the previous size to the UUID standard of 32 digits. Added a new variable to the Storage structure for highly impossible (but not impossible) situations to avoid future panics. Resolved a test case to ensure all tests pass.

Checklist (select as many as applicable)

  • [- ] The code follows the style guidelines of this project.
  • [ -] All new and existing tests pass.
  • [ -] This pull request is ready to be merged and reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: update land id logic
1 participant