Added check for build errors on app/client and on landing page #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solomonsolomonsolomon
requested changes
Dec 21, 2024
| @@ -29,6 +29,34 @@ jobs: | |||
| # working-directory: ./land_registry | |||
| # run: | | |||
| # scarb build | |||
| build: | |||
There was a problem hiding this comment.
duplicate job id with commented code block
| node-version: "18" | ||
|
|
||
| - name: Install dependencies for app/client | ||
| working-directory: app |
There was a problem hiding this comment.
update working directory
| run: npm install | ||
|
|
||
| - name: Build app/client | ||
| working-directory: app |
There was a problem hiding this comment.
update working directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed Information
Added check for build errors on app/client and on landing page
Related Issues
Closes #253