feat: add multicursors-nvim plugin #610
Open
+283
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multicursors-nvim with hydra dependency and static config.
NotAShelf
requested changes
Feb 9, 2025
Comment on lines
+5
to
+7
| options.vim.hydra = { | ||
| enable = mkEnableOption "Creating custom submodes and menus [nvimtools/hydra.nvim]"; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| options.vim.hydra = { | |
| enable = mkEnableOption "Creating custom submodes and menus [nvimtools/hydra.nvim]"; | |
| }; | |
| options.vim.utility.hydra = { | |
| enable = mkEnableOption "utility for creating custom submodes and menus [nvimtools/hydra.nvim]"; | |
| }; |
It's better to have plugins under specific categories instead polluting top-level vim.*. You'll also want to move this under plugins/utility.
Comment on lines
+16
to
+32
| setupOpts = { | ||
| debug = false; | ||
| exit = false; | ||
| foreign_keys = null; | ||
| color = "red"; | ||
| timeout = false; | ||
| invoke_on_body = false; | ||
| hint = { | ||
| show_name = true; | ||
| position = "bottom"; | ||
| offset = 0; | ||
| float_opts = {}; | ||
| }; | ||
| on_enter = null; | ||
| on_exit = null; | ||
| on_key = null; | ||
| }; |
There was a problem hiding this comment.
Is there are a reason we're shipping those defaults? Does the plugin not set any defaults, or are the defaults unergonomic?
|
|
||
| [jahanson](https://github.com/jahanson): | ||
|
|
||
| - Add [multicursors.nvim](https://github.com/smoka7/multicursors.nvim) to |
There was a problem hiding this comment.
Worth mentioning the addition of the hydra.nvim dependency here`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multicursors-nvimwith hydra dependency and config.Added plugin and config for https://github.com/smoka7/multicursors.nvim
Sanity Checking
nix fmt)If new changes are particularly complex:[ ] My code includes comments in particularly complex areas[ ] I have added a section in the manual[ ] (For breaking changes) I have included a migration guide.#nix(default package).#maximal.#docs-html(manual, must build)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.