Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mobs drops #1453

Merged
merged 48 commits into from
Nov 20, 2024
Merged

Update mobs drops #1453

merged 48 commits into from
Nov 20, 2024

Conversation

catgirlseraid
Copy link
Contributor

update mobs drops based off data from bestiary and hypixel wiki + ingame testing

there will be a few more prs like this, split up to make them easier to review. Please comment if i made any mistakes

@catgirlseraid
add dwarven os block bran
40826e5
@catgirlseraid
Revert "add dwarven os block bran"
5694102 
This reverts commit 40826e5.
@catgirlseraid
Merge remote-tracking branch 'origin/master'
0392d6d
@catgirlseraid
first test
9eb69f5
@catgirlseraid
test if combat xp shows up or if cache
5ce2fd1
@catgirlseraid
test if combat xp and farming xp works
db7c226
@catgirlseraid
see if i added multiple levels of mobs correctly
c2ac326
@catgirlseraid
see if i added multiple levels of mobs correctly
c140d7f
@catgirlseraid
see if i added multiple levels of mobs correctly second time
ed8e193
@catgirlseraid
test if mobs can have different names under the same nest
f2d58d4
@catgirlseraid
see if i added silverfish correctly
dca3ac1
@catgirlseraid
fix background maybe
a778f7c
@catgirlseraid
check on spider changes
5b0bdc4
@catgirlseraid
test of adding a new mob what could go wrong
590713b
@catgirlseraid
this time
294a514
@catgirlseraid
maybe it's in the correct section now?
7090bac
@catgirlseraid
bat update 2
e46db37
@catgirlseraid
wrong one
5fc60a7
@catgirlseraid
idk anymore pls just work
fb0ec94
@catgirlseraid
3
9a20cab
@catgirlseraid
maybe this?
a2fd41b
@catgirlseraid
test with another skin
b8f3059
@catgirlseraid
test with another skin with the correct id
216678c
@catgirlseraid
idk anymore
0bbcec3
@catgirlseraid
3
2323866
@catgirlseraid
4
c3a5fbc
@catgirlseraid
5
f89134c
@catgirlseraid
6
1872bf7
@catgirlseraid
test this?
5dcac87
@catgirlseraid
test the same item multiple times
66a4493
@github-actions GitHub Actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

jani270
jani270 reviewed Nov 20, 2024
View reviewed changes
items/GHAST_MONSTER.json Outdated Show resolved Hide resolved
jani270
jani270 reviewed Nov 20, 2024
View reviewed changes
mobs/bat.json Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

@github-actions GitHub Actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

jani270
jani270 reviewed Nov 20, 2024
View reviewed changes
items/BEZAL_MONSTER.json Outdated Show resolved Hide resolved
jani270
jani270 reviewed Nov 20, 2024
View reviewed changes
items/FLARE_MONSTER.json Outdated Show resolved Hide resolved
jani270
jani270 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@jani270 jani270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didnt check every single mob, so trusting you a little bit here. But surely if something is wrong someone will report it
smileW

@jani270 jani270 added this pull request to the merge queue Nov 20, 2024
Merged via the queue into NotEnoughUpdates:master with commit 926e0d5 Nov 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jani270 jani270 jani270 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catgirlseraid @jani270