Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Forest Crystal #1660

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IllagerCaptain
Copy link

@IllagerCaptain IllagerCaptain commented Feb 9, 2025

Forest Crystals, commonly referred to as Bat Crystals, are the floating cubes above roofed forest islands. Unlike other crystals, this one cannot be picked up, but it still has an item form in the API, and can still be obtained in-game in its placed form.

@jani270
Copy link
Collaborator

jani270 commented Feb 9, 2025

this isnt a real item?

@IllagerCaptain
Copy link
Author

this isnt a real item?

It exists. Check the api.

@jani270
Copy link
Collaborator

jani270 commented Feb 9, 2025

this isnt a real item?

It exists. Check the api.

That doesnt make it a real item.

@jani270
Copy link
Collaborator

jani270 commented Feb 9, 2025

The item literally has items that dont exist in the game. E.g Bingo Heirloom

@IllagerCaptain
Copy link
Author

The item literally has items that dont exist in the game. E.g Bingo Heirloom

Screenshot of it on my island:

It exists in the game.

@jani270
Copy link
Collaborator

jani270 commented Feb 9, 2025

The item literally has items that dont exist in the game. E.g Bingo Heirloom

Screenshot of it on my island: It exists in the game.

Okay i know what the skull is, that doesnt make it a real item in the game.

@jani270
Copy link
Collaborator

jani270 commented Feb 9, 2025

There is no point in having this in the repo

@IllagerCaptain
Copy link
Author

The item literally has items that dont exist in the game. E.g Bingo Heirloom

Screenshot of it on my island: It exists in the game.

Okay i know what the skull is, that doesnt make it a real item in the game.

That's not a placed skull, it floats around, spins, produces particles, and spawns bats.

@jani270
Copy link
Collaborator

jani270 commented Feb 9, 2025

The item literally has items that dont exist in the game. E.g Bingo Heirloom

Screenshot of it on my island: It exists in the game.

Okay i know what the skull is, that doesnt make it a real item in the game.

That's not a placed skull, it floats around, spins, produces particles, and spawns bats.

I did not say that its a placed skull?

@IllagerCaptain
Copy link
Author

There is no point in having this in the repo

It has other crystals. Here's screenshots of winter and desert crystals, which are in the repo:

@IllagerCaptain
Copy link
Author

It also exists on the official wiki.

@NopoTheGamer
Copy link
Member

NopoTheGamer commented Feb 9, 2025

  1. The NEU repo only adds actual items that are in game, that real regular players can own 2. what value does the repo gain from having this item

@IllagerCaptain
Copy link
Author

1. The NEU repo only adds actual items that are in game, that real regular players can own

I showed a screenshot of it placed on my island. It is placed by placing the dark forest island, which is craftable.

2. what value does the repo gain from having this item

Quick search-up of all obtainable floating crystals, and range of each.

@NopoTheGamer
Copy link
Member

no item in your inventory, no itemstack representation

@IllagerCaptain
Copy link
Author

IllagerCaptain commented Feb 9, 2025

no item in your inventory, no itemstack representation

That itemstack representation I attached is from the in-game command /viewitem FOREST_ISLAND_CRYSTAL from when that command used item IDs as opposed to item UUIDs. This is the true itemstack representation. But on that note, gemstone crystals are in the repo and besides very early on with jasper and ruby (glacite ones which were never obtainable are in there) are not obtainable as an item. But those are still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants