Close file handles

NotEnoughUpdates · Sep 1, 2024 · f7391de · f7391de
1 parent 533eae7
commit f7391de
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/main/java/io/github/moulberry/repo/NEURepoFile.java b/src/main/java/io/github/moulberry/repo/NEURepoFile.java
@@ -9,6 +9,7 @@
 
 import java.io.IOException;
 import java.io.InputStream;
+import java.io.Reader;
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -26,8 +27,8 @@ public String getPath() {
     private Path fsPath;
 
     public <T> T json(TypeToken<T> type) throws NEURepositoryException {
-        try {
-            return repository.gson.fromJson(Files.newBufferedReader(fsPath, StandardCharsets.UTF_8), type.getType());
+        try (Reader reader = Files.newBufferedReader(fsPath, StandardCharsets.UTF_8)) {
+            return repository.gson.fromJson(reader, type.getType());
         } catch (IOException | SecurityException e) {
             throw new NEURepositoryException(getPath(), "Could not read file", e);
         } catch (JsonSyntaxException e) {
@@ -36,8 +37,8 @@ public <T> T json(TypeToken<T> type) throws NEURepositoryException {
     }
 
     public <T> T json(Class<T> $class) throws NEURepositoryException {
-        try {
-            return repository.gson.fromJson(Files.newBufferedReader(fsPath, StandardCharsets.UTF_8), $class);
+        try (Reader reader = Files.newBufferedReader(fsPath, StandardCharsets.UTF_8)) {
+            return repository.gson.fromJson(reader, $class);
         } catch (IOException | SecurityException e) {
             throw new NEURepositoryException(getPath(), "Could not read file", e);
         } catch (JsonSyntaxException e) {

diff --git a/src/main/java/io/github/moulberry/repo/NEURepositoryVersion.java b/src/main/java/io/github/moulberry/repo/NEURepositoryVersion.java
@@ -9,8 +9,7 @@ public class NEURepositoryVersion {
     public static Properties VERSION_PROPERTIES = new Properties();
 
     static {
-        InputStream resourceAsStream = NEURepositoryVersion.class.getClassLoader().getResourceAsStream("neurepoparser.properties");
-        try {
+        try (InputStream resourceAsStream = NEURepositoryVersion.class.getClassLoader().getResourceAsStream("neurepoparser.properties");) {
             VERSION_PROPERTIES.load(resourceAsStream);
         } catch (IOException | NullPointerException e) {
             new RuntimeException("NEURepositoryVersion could not load neurepoparser.properties.", e).printStackTrace();