-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vscode dev container config and improve main Dockerfile
#433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just for clarification, I got those versions via |
jruths
reviewed
Sep 13, 2024
akevinge
force-pushed
the
feat/vscode-dev-container
branch
from
September 17, 2024 02:25
ee30407
to
f149b30
Compare
akevinge
commented
Sep 24, 2024
As discussed offline, wait until further testing to approve. |
akevinge
force-pushed
the
feat/vscode-dev-container
branch
from
November 12, 2024 03:43
f149b30
to
a67c309
Compare
jpahm
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm assuming the lemon dockerfile issue is the only issue to resolve
Merged
akevinge
force-pushed
the
feat/vscode-dev-container
branch
from
November 13, 2024 01:36
130be0a
to
9ac80cf
Compare
akevinge
force-pushed
the
feat/vscode-dev-container
branch
from
November 13, 2024 23:38
1a65d7f
to
d4fbd53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation will be added in a separate PR.