Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vscode dev container config and improve main Dockerfile #433

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

akevinge
Copy link

Documentation will be added in a separate PR.

@akevinge akevinge requested a review from jruths September 12, 2024 23:58
@akevinge
Copy link
Author

Just for clarification, I got those versions via pip freeze and grepping for them. I tested the full stack on Town02 with no issues.

docker-compose.yml Outdated Show resolved Hide resolved
@akevinge akevinge force-pushed the feat/vscode-dev-container branch from ee30407 to f149b30 Compare September 17, 2024 02:25
docker/entrypoint.sh Outdated Show resolved Hide resolved
@akevinge
Copy link
Author

As discussed offline, wait until further testing to approve.

@akevinge akevinge force-pushed the feat/vscode-dev-container branch from f149b30 to a67c309 Compare November 12, 2024 03:43
@akevinge akevinge requested a review from jpahm November 12, 2024 05:18
Copy link

@jpahm jpahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming the lemon dockerfile issue is the only issue to resolve

@akevinge akevinge mentioned this pull request Nov 12, 2024
@akevinge akevinge force-pushed the feat/vscode-dev-container branch from 130be0a to 9ac80cf Compare November 13, 2024 01:36
@akevinge akevinge force-pushed the feat/vscode-dev-container branch from 1a65d7f to d4fbd53 Compare November 13, 2024 23:38
@akevinge akevinge merged commit b733cff into dev Nov 14, 2024
1 check passed
@akevinge akevinge deleted the feat/vscode-dev-container branch November 14, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants