feat(friends): adding getFriendsFromSource & avatar wrappers #166
Conversation
| } | ||
| let mut friends = Vec::with_capacity(count as usize); | ||
| for idx in 0..count { | ||
| let friend = SteamId(sys::SteamAPI_ISteamFriends_GetFriendFromSourceByIndex( |
There was a problem hiding this comment.
Should this be implemented as an iterator instead?
There was a problem hiding this comment.
the vec is initialized with size count to make it explicit that the index is important.
the steam api requires the index to get further information
what do you think?
There was a problem hiding this comment.
I don't think that's the issue I'm raising here. Forcing this into Vec requires it to allocate on each call. If we had a lazy iterator, the caller can the n decide whether to collect it into a Vec or just iterate/filter/postprocess or whatever they please with it instead.
dan-myles
changed the title
dan-myles
changed the title
|
i've gone ahead an added some more wrappers here for avatar. saw that this hadn't been implemented... as of right now we can only get avatars of "friends" let me know what you think! |
Added a new function wrapper
get_friends_from_source...Unfortunately the name is very misleading. This will not only get "friends" from the source (gameserver, lobby, chat room), but it will return all users. However the steamworks api has it named the same way so I thought I would keep it.
Also it requires a client to be connected to the source in order to work. Once connected you will be able to get all users on that particular gameserver etc.