fix:The database connection is not closed during the catch block #1707
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this instance is not closed, it will result in the occupation of the database file.
When subsequent calls to
setUpWithMigrations
orsetUpWithSchema
reach the execution ofunsafeDestroyEverything
,WatermelonDB/src/adapters/sqlite/index.js
Line 144 in 62774d5
WatermelonDB/src/adapters/sqlite/index.js
Line 195 in 62774d5
Due to the old instance not closing the connection, even though the connection of the new instance is closed, an error
resource busy or locked
still occurs when executingfs.unlinkSync
This fixes #1705