Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to observe on selected columns of a collection #609

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

pranjal-jain
Copy link

@pranjal-jain pranjal-jain commented Jan 20, 2020

Solves #217

  • a Changelog entry
  • describe the feature briefly in the appropriate document in docs-master/ so that others can find this feature
  • name the method(s) experimentalObserveColumns and Q.experimentalSelect
  • add test for the column-only observation function.

@radex
Copy link
Collaborator

radex commented Jan 20, 2020

I know it's WIP, but a few things will be required:

  • a Changelog entry
  • describe the feature briefly in the appropriate document in docs-master/ so that others can find this feature
  • please name the method(s) experimentalObserveColumns and Q.experimentalSelect -- the reason is that I'm not yet sure if this is the right API to express those features, and so I want to be able to rename this/change slightly later.
  • add test for the column-only observation function. You can take a look at other observer tests for inspiration

Thanks so much for contributing @pranjal-jain!

@pranjal-jain pranjal-jain marked this pull request as ready for review January 30, 2020 12:14
@pranjal-jain
Copy link
Author

@radex Thanks for taking out time to review this. I have made the changes requested by you.

I have exposed experimentalObserveColumns(['col1', 'col2']) and experimentalFetchColumns(['col1', 'col2']) on Query.

Let me know if you have a better API in mind to expose this feature.

@radex radex self-assigned this Jan 30, 2020
@radex
Copy link
Collaborator

radex commented Jan 30, 2020

amazing @pranjal-jain! Thanks for doing this work! I will try to check out the PR in the next week or so

@pranjal-jain
Copy link
Author

@radex Waiting for you to review this whenever you get time.

@stale
Copy link

stale bot commented Aug 23, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Aug 23, 2020
@stale stale bot closed this Sep 13, 2020
@radex radex reopened this Sep 14, 2020
@stale stale bot removed the wontfix This will not be worked on label Sep 14, 2020
@stale
Copy link

stale bot commented Jun 16, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Jun 16, 2021
@radex radex removed the wontfix This will not be worked on label Jun 17, 2021
@zhirzh
Copy link
Contributor

zhirzh commented Nov 10, 2021

@pranjal-jain @radex I have merged these changes into latest master here pranjal-jain#4. With latest master merged, here's the updated diff with nozbe/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants