Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common mistakes docs #615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Common mistakes docs #615

wants to merge 1 commit into from

Conversation

esbenp
Copy link
Contributor

@esbenp esbenp commented Jan 31, 2020

Ref #612

I gave it a try @radex . I am having a hard time coming up with a great example that demonstrates "do not put await between prepareUpdate and batch. This is the best I could come up with, but it also includes a logic flaw (since comments.fetch() would not include the newly updated comments and therefore total_good_comments is wrong). Do you have any feedback for a better example and/or better wordings?

@stale
Copy link

stale bot commented Jul 29, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Jul 29, 2020
@stale stale bot closed this Aug 22, 2020
@olliewd
Copy link
Contributor

olliewd commented Jul 25, 2021

Just wanted to say thanks. I actually found this helpful, and it enabled me to solve a bug I was having.

I don't think it's super obvious (?) that prepareUpdates can't be called multiple times in the same batch for the same record. Maybe this could be signalled in the docs somehow, or maybe the pull request could be accepted?

@radex radex removed the wontfix This will not be worked on label Jul 26, 2021
@radex radex reopened this Jul 26, 2021
@stale
Copy link

stale bot commented Apr 27, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix This will not be worked on label Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants