-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add comment for coordinating with other .NET repos for relevant deps #6024
Conversation
<NewtonsoftJsonPackageVersion Condition="'$(NewtonsoftJsonPackageVersion)' == ''">13.0.3</NewtonsoftJsonPackageVersion> | ||
<SystemFormatsAsn1PackageVersion Condition="'$(SystemFormatsAsn1PackageVersion)' == ''">8.0.1</SystemFormatsAsn1PackageVersion> | ||
|
||
<!-- Do not update the version of System.Text.Json without explicit approval from the .NET SDK and .NET MsBuild repo owners. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a quick glance, I was unable to identify the changes proposed in this pull request. Therefore, I am adding this review comment to help team members understand the proposed changes. In summary, the <!-- Do not update the version of System.Text.Json without explicit approval from the .NET SDK and .NET MsBuild repo owners. -->
comment has been added in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Kartheek. Why is this document completely modified? Was the indentation wrong before, or is it wrong now?
Please try reverting and just adding the comment to minimize the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird... I used GitHub Web Editor, which shows the expected diff. However, GitHub itself shows that the entire file changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pressing .
on github on this PR opens https://github.dev/NuGet/NuGet.Client/pull/6024.
From there, opening Directory.Packages.props, vscode shows at the bottom of the screen: UTF-8 CRLF
.
Editing the URL to https://github.dev/NuGet/NuGet.Client/ and again opening Directory.Packages.props, it now says UTF-8 LF
So, github changed every line ending from LF to CRLF. It did the wrong thing:
Lines 1 to 2 in 785d8bb
# Auto detect text files and perform LF normalization | |
* text=auto |
For what it's worth, I'm preparing a branch that will split package versions depending if the project inserts into the .NET SDK or not, because for some packages, it's necessary due to the VS SDK to avoid package downgrade warnings. I'll be adding comments similar to what I added in this release-6.11.x fix: https://github.com/NuGet/NuGet.Client/pull/6015/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, github did not do the wrong thing, the dev branch has the wrong line endings
Line 62 in 785d8bb
*.props text eol=crlf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I hear otherwise, I'm going to send a PR just to update to CRLF, then rebase this branch against that.
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
Did this get lost? |
Yeah. Whitespace handling by the tooling is making it too hard to rebase this PR, so I just created a new one: https://github.com/NuGet/NuGet.Client/pull/6112/files |
Description
As a follow up to dotnet/sdk#43339, add a comment for coordinating with other .NET repos for relevant dependencies:
PR Checklist