Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Jsappybird workshop to pt-br #401

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

aminueza
Copy link
Contributor

This PR changes:

  • add brazilian portuguese tranlation for JSappyBird workshop

@aminueza
Copy link
Contributor Author

Requesting double check from @pasilva-msft :)

Copy link
Member

@ozhang22 ozhang22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review

content/brazilian-portuguese/jsappybird/_index.md Outdated Show resolved Hide resolved
Copy link

@pasilva-msft pasilva-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions/comments.

content/brazilian-portuguese/jsappybird/index_1.md Outdated Show resolved Hide resolved
content/brazilian-portuguese/jsappybird/load-the-bird.md Outdated Show resolved Hide resolved
@aminueza
Copy link
Contributor Author

@pasilva-msft PR is done with suggestions, could you please check it again? :)

Copy link

@pasilva-msft pasilva-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added new words to fix translation.

- `index.html`, onde o jogo será exibido.
- `main.js`, o arquivo onde vamos escrever nosso código.
- `assets/`, uma pasta com 2 imagens.
- Atividate `1.js`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be translated as "Atividade". Same for the lines 21 and 22.

hidden: true
---

![alt text](resources/_gen/images/flappy.png "JSappyBird")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move all the stuff in the "" into the [] to replace alt text for all cases?

Suggested change
![alt text](resources/_gen/images/flappy.png "JSappyBird")
![JSappyBird](resources/_gen/images/flappy.png)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants