-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate Jsappybird workshop to pt-br #401
base: master
Are you sure you want to change the base?
Conversation
Requesting double check from @pasilva-msft :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions/comments.
@pasilva-msft PR is done with suggestions, could you please check it again? :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added new words to fix translation.
- `index.html`, onde o jogo será exibido. | ||
- `main.js`, o arquivo onde vamos escrever nosso código. | ||
- `assets/`, uma pasta com 2 imagens. | ||
- Atividate `1.js` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be translated as "Atividade". Same for the lines 21 and 22.
hidden: true | ||
--- | ||
|
||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move all the stuff in the "" into the [] to replace alt text for all cases?
 | |
 |
This PR changes: