Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start support for dynamic segments #11

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Start support for dynamic segments #11

wants to merge 1 commit into from

Conversation

NullVoxPopuli
Copy link
Owner

No description provided.

@NullVoxPopuli NullVoxPopuli force-pushed the support-dynamic-segments branch from 5feb082 to e98e64e Compare June 11, 2019 19:17
@NullVoxPopuli NullVoxPopuli changed the title Start support dynamic sugments Start support for dynamic segments Jun 16, 2019
@cah-brian-gantzler
Copy link
Contributor

What was the intent here? Since we are talking about the cache and dynamic segments

@NullVoxPopuli
Copy link
Owner Author

looks like the intent was to have separate sets of query params per dynamic segment

@cah-brian-gantzler
Copy link
Contributor

I think that is what you are getting right now because you are using path.

So, should path be configurable or just switch to routeName?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NullVoxPopuli @cah-brian-gantzler